Allow infinite ActiveState change listeners. #222
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a warning from event-emitter when using more than ten Links (or other components using the ActiveState mixin).
|
I think this seems reasonable to me… |
Fix for an error being thrown in Routes.js - updateMatchComponents.
| @@ -281,7 +281,7 @@ function getRootMatch(matches) { | |||
|
|
|||
| function updateMatchComponents(matches, refs) { | |||
| var i = 0, component; | |||
| while (component = refs[REF_NAME]) { | |||
| while ((component = refs[REF_NAME]) && (matches[i+1] !== undefined)) { | |||
There was a problem hiding this comment.
What's this all about? I remember debugging this code a while ago, can't remember why I was here though.
I'd like to know whats happening, not just prevent an error from happening.
There was a problem hiding this comment.
Oh shit, that's not supposed to be there, I commited it to my fork after submitting the pull request. Didn't realize it would be added here (like I said, I'm new at this). Anyway, it's my proposed fix for #117.
This reverts commit fa4127f.
|
closed by edbfd25 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a warning from event-emitter when using more than ten Links (or
other components using the ActiveState mixin) by allowing an unlimited number of listeners (as suggested here: http://nodejs.org/docs/latest/api/events.html#events_emitter_setmaxlisteners_n).
This is to try to fix issue #220.
Or would it be better to somehow group event listeners? Or is there some other way of solving this problem?
(Sorry if I'm doing this wrong, haven't done a pull request before.)